Implemented special handling for -nodebug flag #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-bezrukov
changed the title
levonpetrosyan93
previously approved these changes
Apr 27, 2021
psolstice
requested changes
Apr 27, 2021
src/util.cpp
Outdated
| if (str.size() < 6) | ||
| return 0; | ||
| else if (strncmp(str.data(), "ERROR:", 6) != 0) | ||
| return 0; |
There was a problem hiding this comment.
there is much more elegant way to do the comparison
if (str.compare(0, 6, "ERROR:") != 0)
return 0;
psolstice
approved these changes
Apr 27, 2021
levonpetrosyan93
approved these changes
Apr 27, 2021
|
This pull request introduces 3 alerts when merging 8482413 into e0bc12b - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR intention
Suppress all the log messages except those start with "ERROR:".
Code changes brief
Added a temporary flag fNoDebug. Bitcoin 0.17 introduces a redesign which have this logic fixed.